More test tools for IO pipeline + cleanups #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rotating GeoBoxes around center - Generate image pair that contains X,Y coords of image centers
Not sure why it was omitted, took me a while to figure out why VSCode wouldn't see these tests.
Codecov Report
@@ Coverage Diff @@
## develop #617 +/- ##
===========================================
+ Coverage 87.1% 87.55% +0.44%
===========================================
Files 94 93 -1
Lines 8385 8411 +26
===========================================
+ Hits 7304 7364 +60
+ Misses 1081 1047 -34
Continue to review full report at Codecov.
|
For generating test images such that you can reconstruct X,Y coordinate from pixel value. xy_norm takes output of xy_from_gbox and normalises it with a reversible transform such that values are in (0,1) range and gradient is not left/right, top/down but rather at an angle.
rotation when seen from the pixel plane depends on which axis are inverted, so mentioning that.
rather than returning dictionaries return `SimpleNamespace` from `rio_slurp` and `write_gtiff` functions in `testutils.io.` module.
Changes resolution of GeoBox covering the same region as original
If reading with shape change geobox for output is different than geobox for whole image.
Kirill888
force-pushed
the
io-more-tests
branch
from
2a4eccd
to
dda1185
Compare
Geobox when supplied takes precedence over resolution,offset,crs triplet
be consistent with normal read when dealing with multi-band files, i.e. reproject all bands not just first one.
Call to `denorm()` without arguments returns Affine matrix used to denormalise images.
dtype argument wasn't passed on/tested
Transform a bunch of points stored as x,y ndarrays from one projection to another.
- remove no longer used constants - remove python2 imports - remove unused imports - remove duplicate constants - remove some intermediate constants - convert old style type annotations to py3 - clean up of stale type annotations
python2 is no longer supported so removing more of the left overs
Kirill888
force-pushed
the
io-more-tests
branch
from
033df48
to
b2f3006
Compare
Mypy fixes in base libs - adding `# type: ignore` on overly dynamic things like memoized methods. - converting some of old-style type annotations to py3
Kirill888
force-pushed
the
io-more-tests
branch
from
b2f3006
to
f7ff0e0
Compare
Kirill888
changed the title
omad
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
compat.pysixlibraryDidn't get to start using these images for tests yet as PR grew big already.
Proposed changes
Use test images that encodex,ycoordinates of pixel location to test that "correct enough" source pixels end up in the destination image.integration_testsdirectory topytestconfig file (not sure why it was omitted)