Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Update JSP to 0.4.1 #94

Merged

Conversation

vpavlin
Copy link

@vpavlin vpavlin commented May 17, 2021

Related Issues and Dependencies

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

… Explain your changes.

Description

This PR updates JupyterHub Singleuser Profiles to 0.4.0 - see changelog: opendatahub-io-contrib/jupyterhub-singleuser-profiles#143

@vpavlin
Copy link
Author

vpavlin commented May 17, 2021

@LaVLaS Hey, here is the updated JH image with the new UI

@vpavlin vpavlin requested a review from LaVLaS May 17, 2021 15:23
@LaVLaS
Copy link

LaVLaS commented May 18, 2021

I noticed two similar errors in the logs when there were imagestreams with no tags or imagestreamtags with tags[].annotations=null

[I 2021-05-18 02:50:14.914 JupyterHub service:121] Spawning jupyterhub-singleuser-profiles-api
02:50:15.517 [ConfigProxy] �[32minfo�[39m: 200 GET /api/routes
Traceback (most recent call last):
  File "/opt/app-root/bin/jupyterhub-singleuser-profiles-api", line 5, in <module>
    from jupyterhub_singleuser_profiles.api.api import main
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/api/api.py", line 19, in <module>
    _PROFILES = SingleuserProfiles(verify_ssl=False)
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/profiles.py", line 38, in __init__
    self.user = User(self.openshift, default_image=self.images.get_default())
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/images.py", line 43, in get_default
    image_list = self.load()
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/images.py", line 76, in load
    software=json.loads(tag.annotations.get(SOFTWARE_ANNOTATION, "[]")),\
AttributeError: 'NoneType' object has no attribute 'get'
[2021-05-18 03:15:58,260] ERROR in app: Exception on /services/jsp-api/api/images [GET]
Traceback (most recent call last):
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 2051, in wsgi_app
    response = self.full_dispatch_request()
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1501, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1499, in full_dispatch_request
    rv = self.dispatch_request()
  File "/opt/app-root/lib/python3.6/site-packages/flask/app.py", line 1485, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/decorator.py", line 48, in wrapper
    response = function(request)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/uri_parsing.py", line 144, in wrapper
    response = function(request)
  File "/opt/app-root/lib/python3.6/site-packages/connexion/decorators/parameter.py", line 121, in wrapper
    return function(**kwargs)
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/api/api.py", line 52, in decorated
    return f(user=user, *args, **kwargs)
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/api/api.py", line 107, in get_images
    images = _PROFILES.images.get()
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/images.py", line 88, in get
    result = self.load()
  File "/opt/app-root/lib/python3.6/site-packages/jupyterhub_singleuser_profiles/images.py", line 76, in load
    software=json.loads(tag.annotations.get(SOFTWARE_ANNOTATION, "[]")),\
AttributeError: 'NoneType' object has no attribute 'get'

@vpavlin
Copy link
Author

vpavlin commented May 20, 2021

@LaVLaS I am happy to release a new JSP version - here is the fix: opendatahub-io-contrib/jupyterhub-singleuser-profiles#144

@LaVLaS
Copy link

LaVLaS commented May 20, 2021

The spawner UI works with no issues when using properly annotated imagestreamtags

@vpavlin vpavlin changed the title Update JSP to 0.4.0 Update JSP to 0.4.1 May 27, 2021
Copy link

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

No error logs with null annotations on the imagestreamtags

@vpavlin vpavlin merged commit 4f844d3 into opendatahub-io-contrib:master May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants