This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
forked from jupyter-on-openshift/poc-hub-openshift-auth
-
Notifications
You must be signed in to change notification settings - Fork 31
Update JSP to 0.4.1 #94
Merged
vpavlin
merged 1 commit into
opendatahub-io-contrib:master
from
vpavlin:feature/update-jsp-0.4.0
May 31, 2021
Merged
Update JSP to 0.4.1 #94
vpavlin
merged 1 commit into
opendatahub-io-contrib:master
from
vpavlin:feature/update-jsp-0.4.0
May 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@LaVLaS Hey, here is the updated JH image with the new UI |
I noticed two similar errors in the logs when there were imagestreams with no tags or imagestreamtags with
|
@LaVLaS I am happy to release a new JSP version - here is the fix: opendatahub-io-contrib/jupyterhub-singleuser-profiles#144 |
The spawner UI works with no issues when using properly annotated imagestreamtags |
vpavlin
force-pushed
the
feature/update-jsp-0.4.0
branch
from
May 27, 2021 15:02
e34d96f
to
7831c5d
Compare
LaVLaS
approved these changes
May 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
No error logs with null annotations
on the imagestreamtags
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
… Explain your changes.
Description
This PR updates JupyterHub Singleuser Profiles to 0.4.0 - see changelog: opendatahub-io-contrib/jupyterhub-singleuser-profiles#143