Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1373 - Remove the individual build and test pipelines #198

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

MarianMacik
Copy link
Member

JIRA: RHOAIENG-1373

Description

  • Build & Test pipelines have been moved under the /pipelines/tekton/obsolete/ directory with a separate README file.
  • aiedge-e2e README parts were moved to the parent README under the /pipelines/tekton/ directory and the original README was removed.
  • Minor improvements to the secret naming and various other documentation fixes.

How Has This Been Tested?

It's mainly documentation update, so no need for any automated testing.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member Author

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few questions because I wasn't sure @LaVLaS.

Also, in case you would like to have the old pipelines somewhere else (or use deprecated instead of obsolete), just tell.

README.md Outdated Show resolved Hide resolved
pipelines/README.md Show resolved Hide resolved
@MarianMacik
Copy link
Member Author

@LaVLaS all comments addressed.

@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 1, 2024

/lgtm

Looks great! I updated the merge conflict.

@openshift-ci openshift-ci bot added the lgtm label Feb 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 42df147 into opendatahub-io:main Feb 1, 2024
2 checks passed
Sara4994 pushed a commit to Sara4994/ai-edge that referenced this pull request Feb 5, 2024
RHOAIENG-1373 - Remove the individual build and test pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants