Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4617] - follow up - remove hardcoded fastapi from Dockerfile #292

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Apr 10, 2024

As the Ray Serve latest release removed the hard dependency of old fastapi version we can now remove the workaround from the Storage Initializer Container Image.

Release note:

NONE

As the Ray Serve latest release removed the hard dependency of old fastapi version
we can now remove the workaround from the Storage Initializer Container Image.

Signed-off-by: Spolti <fspolti@redhat.com>
@spolti
Copy link
Member Author

spolti commented Apr 10, 2024

/retest

1 similar comment
@spolti
Copy link
Member Author

spolti commented Apr 10, 2024

/retest

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spolti
Copy link
Member Author

spolti commented Apr 10, 2024

/retest

7 similar comments
@spolti
Copy link
Member Author

spolti commented Apr 10, 2024

/retest

@spolti
Copy link
Member Author

spolti commented Apr 11, 2024

/retest

@spolti
Copy link
Member Author

spolti commented Apr 11, 2024

/retest

@spolti
Copy link
Member Author

spolti commented Apr 12, 2024

/retest

@spolti
Copy link
Member Author

spolti commented Apr 12, 2024

/retest

@spolti
Copy link
Member Author

spolti commented Apr 12, 2024

/retest

@israel-hdez
Copy link

/retest

Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [israel-hdez,spolti,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Spolti <fspolti@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 23, 2024
Copy link

openshift-ci bot commented Apr 23, 2024

New changes are detected. LGTM label has been removed.

@spolti spolti added the lgtm label Apr 24, 2024
@spolti spolti merged commit a3155d8 into opendatahub-io:master Apr 30, 2024
27 of 29 checks passed
@spolti spolti deleted the RHOAIENG-4617 branch April 30, 2024 01:14
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 3, 2024
opendatahub-io#292)

* [RHOAIENG-4617] - follow up - remove hardcoded fastapi from Dockerfile

As the Ray Serve latest release removed the hard dependency of old fastapi version
we can now remove the workaround from the Storage Initializer Container Image.

Signed-off-by: Spolti <fspolti@redhat.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
opendatahub-io#292)

* [RHOAIENG-4617] - follow up - remove hardcoded fastapi from Dockerfile

As the Ray Serve latest release removed the hard dependency of old fastapi version
we can now remove the workaround from the Storage Initializer Container Image.

Signed-off-by: Spolti <fspolti@redhat.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
opendatahub-io#292)

* [RHOAIENG-4617] - follow up - remove hardcoded fastapi from Dockerfile

As the Ray Serve latest release removed the hard dependency of old fastapi version
we can now remove the workaround from the Storage Initializer Container Image.

Signed-off-by: Spolti <fspolti@redhat.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 6, 2024
opendatahub-io#292)

* [RHOAIENG-4617] - follow up - remove hardcoded fastapi from Dockerfile

As the Ray Serve latest release removed the hard dependency of old fastapi version
we can now remove the workaround from the Storage Initializer Container Image.

Signed-off-by: Spolti <fspolti@redhat.com>
xieshenzh pushed a commit to xieshenzh/kserve that referenced this pull request Jul 11, 2024
…p/component-updates/kserve-router-210

Update kserve-router-210 to 1875879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants