Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included habana based imagestream to the notebook manifests #233

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Included habana based imagestream to the notebook manifests #233

merged 1 commit into from
Oct 6, 2023

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Oct 4, 2023 •
edited
Loading

Included habana based imagestream to the notebook manifests

Description

Include habana based imagestream to the notebook manifests
Related-to: #96 #240

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

atheo89
atheo89 requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating HabanaAI notebooks into the manifests! I've included a few change requests in this review.

@atheo89
Copy link
Member

atheo89 commented Oct 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 5, 2023
@harshad16
Included habana based imagestream to the notebook manifests
fd0a348 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Oct 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

New changes are detected. LGTM label has been removed.

@harshad16
Copy link
Member Author

Thanks for the review
Merging this to get the release ready.
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2023
@harshad16 harshad16 merged commit 1832a3f into opendatahub-io:main Oct 6, 2023
0 of 4 checks passed
@harshad16 harshad16 mentioned this pull request Oct 10, 2023
Closed
@harshad16 harshad16 deleted the habana-imagestream branch October 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 requested changes

@dibryant dibryant Awaiting requested review from dibryant

Assignees

@atheo89 atheo89

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshad16 @atheo89