Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trustyAI test_notebooks #517

Merged
merged 1 commit into from
May 2, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Apr 30, 2024

This is a follow up PR for this: #510

Update trustyAI test_notebook to include the tests from minimal and datascience due to python package inconsistencies

Description

How Has This Been Tested?

Tested the ubi9 test_notebok.ipynb flavor in ODH using TrustyAI 2024.1 workbench

You should see the following results:

test_create_default_session (__main__.TestBoto3) ... ok
test_version (__main__.TestBoto3) ... ok
test_jupyter_version (__main__.TestDependenciesVersions) ... ok
test_nbdime_version (__main__.TestDependenciesVersions) ... ok
test_nbgitpuller_version (__main__.TestDependenciesVersions) ... ok
test_buffer_pool (__main__.TestKafkaPython) ... ok
test_session_timeout_larger_than_request_timeout_raises (__main__.TestKafkaPython) ... ok
test_version (__main__.TestKafkaPython) ... ok
test_matplotlib_figure_creation (__main__.TestMatplotlib) ... ok
test_version (__main__.TestMatplotlib) ... ok
test_array_creation (__main__.TestNumpy) ... ok
test_array_opeartions (__main__.TestNumpy) ... ok
test_array_statistical_functions (__main__.TestNumpy) ... ok
test_version (__main__.TestNumpy) ... ok
test_dataframe_creation (__main__.TestPandas) ... ok
test_dataframe_shape (__main__.TestPandas) ... ok
test_drop (__main__.TestPandas) ... ok
test_equal_dataframes (__main__.TestPandas) ... ok
test_index_out_of_bounds (__main__.TestPandas) ... ok
test_sampling (__main__.TestPandas) ... ok
test_unequal_dataframes (__main__.TestPandas) ... ok
test_version (__main__.TestPandas) ... ok
test_version (__main__.TestPythonVersion) ... ok
test_sklearn_dataset (__main__.TestSKLearn) ... ok
test_sklearn_train_test_split (__main__.TestSKLearn) ... ok
test_version (__main__.TestSKLearn) ... ok
test_scipy_integrate (__main__.TestScipy) ... ok
test_scipy_special (__main__.TestScipy) ... ok
test_version (__main__.TestScipy) ... ok
test_datafairness (__main__.TestTrustyaiNotebook) ... ok
test_fairnessmetrics (__main__.TestTrustyaiNotebook) ... ok
test_trustyai_version (__main__.TestTrustyaiNotebook) ... ok

Or should wait the CI to build the two trustyAI workbenches and then run
podman run -it --rm -p 8888:8888 ${TrustyAI_CI_notebook}
and run inside the test_notebook.ipynb (ubi8 & ubi9)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 changed the title Update trustyAI test_notebook Update trustyAI test_notebooks Apr 30, 2024
…atascience due to python package inconsistencies
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 154bfc3 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atheo89 atheo89 merged commit 6aa55c9 into opendatahub-io:main May 2, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants