-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Server (vs code) notebook based on the new CentOS base image with python 3.9 #84
Add Code Server (vs code) notebook based on the new CentOS base image with python 3.9 #84
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
just one change we require
534b0c1
to
4112c2f
Compare
/retest-required |
4112c2f
to
4924982
Compare
/test notebooks-e2e-tests |
1 similar comment
/test notebooks-e2e-tests |
/test notebooks-e2e-tests |
1 similar comment
/test notebooks-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
small suggestion regarding the base image.
4924982
to
ea74d6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror |
/retest-required |
1 similar comment
/retest-required |
…44487 [main] hot-fix: Fixed imagestream with CVE 44487 changes
This PR introduces the new Code Server (vs code) notebook into the list of the OOTB images.
Open Issue: #73
Merge Note: CI PR should be merged first openshift/release#39220
Description
This notebook is derived from the new base image
base-c9s-python-3.9
How Has This Been Tested?
Create the image by run:
make codeserver-c9s-python-3.9
Run the Image locally:
podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:codeserver-c9s-python-3.9-pr-84
When you finish the inspection:
podman stop validation-container && podman rm validation-container
Deploy:
make deploy-c9s-codeserver-c9s-python-3.9
Test:
make validate-codeserver-image image=codeserver-c9s-python-3.9-2023a_YYYYMMDD
Undeploy:
make undeploy-c9s-codeserver-c9s-python-3.9
Merge criteria: