Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Server (vs code) notebook based on the new CentOS base image with python 3.9 #84

Merged

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented May 10, 2023

This PR introduces the new Code Server (vs code) notebook into the list of the OOTB images.

Open Issue: #73

Merge Note: CI PR should be merged first openshift/release#39220

Description

This notebook is derived from the new base image base-c9s-python-3.9

How Has This Been Tested?

Create the image by run: make codeserver-c9s-python-3.9

Run the Image locally:
podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:codeserver-c9s-python-3.9-pr-84

image

When you finish the inspection: podman stop validation-container && podman rm validation-container

Deploy: make deploy-c9s-codeserver-c9s-python-3.9
Test: make validate-codeserver-image image=codeserver-c9s-python-3.9-2023a_YYYYMMDD
Undeploy: make undeploy-c9s-codeserver-c9s-python-3.9

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@atheo89 atheo89 marked this pull request as ready for review May 10, 2023 17:24
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just one change we require

Makefile Outdated Show resolved Hide resolved
@atheo89
Copy link
Member Author

atheo89 commented May 11, 2023

/retest-required

@atheo89
Copy link
Member Author

atheo89 commented May 11, 2023

/test notebooks-e2e-tests

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented May 11, 2023

/test notebooks-e2e-tests

@atheo89 atheo89 linked an issue May 11, 2023 that may be closed by this pull request
@harshad16
Copy link
Member

/test notebooks-e2e-tests

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented May 12, 2023

/test notebooks-e2e-tests

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

small suggestion regarding the base image.

base/c9s-python-3.9/Dockerfile Outdated Show resolved Hide resolved
base/c9s-python-3.9/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

@openshift-ci openshift-ci bot added the lgtm label May 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented May 15, 2023

/test notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror

@atheo89
Copy link
Member Author

atheo89 commented May 15, 2023

/retest-required

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented May 15, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit e340977 into opendatahub-io:main May 15, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request May 26, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request May 26, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 27, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Oct 31, 2023
…44487

[main] hot-fix: Fixed imagestream with CVE 44487 changes
@atheo89 atheo89 deleted the vs-server-notebook branch October 23, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Code Server (VSCode) notebook image out of the box
3 participants