Add a GPU setting to the config to allow more control over the field & it's values #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewballantyne: UX suggests changing the wording to “GPU availability is unverified” |
lucferbux
approved these changes
Oct 25, 2022
|
Wording and screenshot updated |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
lucferbux
pushed a commit
to lucferbux/odh-dashboard
that referenced
this pull request
Oct 25, 2022
…& it's values (opendatahub-io#694) * Add a GPU setting to the config to allow more control over the field & it's values * Added wording from UX
andrewballantyne
added a commit
that referenced
this pull request
Oct 25, 2022
…& it's values (#694) * Add a GPU setting to the config to allow more control over the field & it's values * Added wording from UX
lucferbux
pushed a commit
to red-hat-data-services/odh-dashboard
that referenced
this pull request
Oct 26, 2022
…& it's values (opendatahub-io#694) * Add a GPU setting to the config to allow more control over the field & it's values * Added wording from UX
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
…& it's values (opendatahub-io#694) * Add a GPU setting to the config to allow more control over the field & it's values * Added wording from UX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#680
Description
Added
spec.notebookController.gpuSetting, following are the possible values...At zero:
Dropdown goes from 0 to that desired number, in this case the setting was "5"
At any custom number has a warning
Merge criteria: