Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump model-registry to v0.1.1 #165

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

lampajr
Copy link
Contributor

@lampajr lampajr commented Feb 20, 2024

Description

Update the model-registry library to the lates tag https://github.com/opendatahub-io/model-registry/releases/tag/v0.1.1.

Updated the e2e test to make use of that version for the container as well.

How Has This Been Tested?

Unit tests:

make test

and e2e tests:

kind create cluster --config test/config/kind-e2e-config.yaml
IMG=quay.io/$USER/odh-model-controller:$(git rev-parse HEAD) && make IMG=$IMG docker-build && kind load docker-image $IMG
make IMG=${IMG} deploy-dev
make e2e-test

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lampajr
Copy link
Contributor Author

lampajr commented Feb 20, 2024

/test all

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, lampajr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 19ac24d into opendatahub-io:main Feb 21, 2024
5 checks passed
@lampajr lampajr deleted the update_mr_lib branch February 21, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants