Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PA health facility data sets #198

Merged
merged 13 commits into from
May 3, 2024
Merged

Add new PA health facility data sets #198

merged 13 commits into from
May 3, 2024

Conversation

rcheetham
Copy link
Collaborator

@rcheetham rcheetham added the data catalog add or update ODP data catalog entries label Apr 27, 2024
@rcheetham rcheetham changed the title Create pa-birth-centers Add new PA health facility data sets Apr 27, 2024
BryanQuigley
BryanQuigley requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build broken, maybe from some datasets not having .md extension will review more later

@lydiascarf
Ensure all datasets have file extensions (.md)
9f03219 
I used the following:
```
for f in *; do case "$f" in *.*) echo skipped $f;; *) mv "$f" "$f".md; esac; done
```
@lydiascarf
Escape colon in yaml string value
eebc76d
@lydiascarf lydiascarf mentioned this pull request May 2, 2024
Merged
@lydiascarf
Copy link
Collaborator

i fixed two things:

  • one was the md extension issue Bryan mentioned
  • the other was a colon in a yaml value that needed to be escaped

i'll give a full review when i get another minute!

@BryanQuigley BryanQuigley self-requested a review May 3, 2024 04:30
BryanQuigley
BryanQuigley approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@BryanQuigley BryanQuigley merged commit 4d05f4c into main May 3, 2024
3 checks passed
@BryanQuigley BryanQuigley deleted the rcheetham-patch-pa-health branch May 3, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanQuigley BryanQuigley BryanQuigley approved these changes

@lydiascarf lydiascarf Awaiting requested review from lydiascarf

Assignees
No one assigned
Labels
data catalog add or update ODP data catalog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcheetham @lydiascarf @BryanQuigley