Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use google-libphonenumber instead #1

Conversation

ruimarinho
Copy link
Contributor

I've replaced the existing libphonenumber implementation for google-libphonenumber, which I currently maintain. The last metadata update from the previous library dates back to June of 2014 (the most recent metadata available is from February of 2015).

google-libphonenumber is exactly like the original library but repackaged for node. No additional APIs or methods are exposed. You can read more about the differences from other forks.

Hope it helps!

@SebastienElet
Copy link
Member

Hello,

Please could you had the updated package.json to your PR to fix the travis build ?

Thanks.

@ruimarinho ruimarinho force-pushed the enhancement/use-google-libphonenumber-instead branch from 1eea782 to 2c1b230 Compare March 9, 2015 11:07
@ruimarinho
Copy link
Contributor Author

My bad. Fixed!

SebastienElet added a commit that referenced this pull request Mar 9, 2015
…nenumber-instead

Use google-libphonenumber instead of libphonenumber
@SebastienElet SebastienElet merged commit 4fd456b into opendena:master Mar 9, 2015
@SebastienElet
Copy link
Member

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants