Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another variable assignment with a combined operator for string concatenations #684

Closed
elfring opened this issue Nov 26, 2021 · 6 comments
Labels

Comments

@elfring
Copy link

elfring commented Nov 26, 2021

👀 Some source code analysis tools can help to find opportunities for improving software components.
💭 I propose to increase the usage of combined operators accordingly.

diff --git a/src/DevShop/Command/DevmasterUpgrade.php b/src/DevShop/Command/DevmasterUpgrade.php
index 2ac7a15ef..308b459a1 100644
--- a/src/DevShop/Command/DevmasterUpgrade.php
+++ b/src/DevShop/Command/DevmasterUpgrade.php
@@ -156,7 +156,7 @@ class DevmasterUpgrade extends Command
         $number++;
       }
       $output->writeln("File DOES NOT exists at " . $target_path . '-' . $number);
-      $target_path = $target_path . '-' . $number;
+      $target_path .= '-' . $number;
     }
 
     $output->writeln('');
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jun 12, 2022
@elfring
Copy link
Author

elfring commented Jun 12, 2022

🔮 Will the chances grow to adjust the shown assignment statement?

@stale
Copy link

stale bot commented Jun 12, 2022

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jun 12, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

1 similar comment
@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Dec 24, 2022
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

@stale stale bot closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant