Sonarqube stage crashes in cnes report

[jssnull]

If we've an ods quickstarter, and we create a PR for it.
If we trigger a build in the PR origin branch, the jenkins build will crash in sonarqube stage, concretely, when the cnes report
is called. It will retrieve an error like this:

java -jar /usr/local/cnes/cnesreport.jar -s https://mysonarinstance -t ****** -p myproject-mycomponent -a jenkins-mycomponent-cd-myproject-cd-mycomponent-develop-1 -b develop
SonarQube URL: https://mysonarinstance
SonarQube online: true
Detected SonarQube version: 8.2.0
[ERROR] Not found error sent by SonarQube server (code 404, URL https://mysonarinstance/api/navigation/component?component=myproject-mycomponent&branch=develop, Error {"errors":[{"msg":"Component 'myproject-mycomponent' on branch 'develop' not found"}]}), please check cnesreport compatibility with your SonarQube server version.

After having this error, If we delete the created PR and launch a build in the same branch again, it will work.
Then, seems that the cnes report is not able to retrieve data from PR in sonarqube. This happens in sonarqube developer and above editions.

Seems that in the past, situations like this happened in cnes plugin: cnescatlab/sonar-cnes-report#159

[metmajer]

@jssnull when you create an issue that breaks relevant behavior of our Platform, please ensure there's some traction on the topic. Especially if you are tackling this from a support perspective. Did you already include any people that can help you on that matter?

[s2oBCN]

The problem is because cnes-report (SonarQu tool) is not compatible with PR scan. cnescatlab/sonar-cnes-report#159

This is because the scan is done against the PR and not against the Branch. To solve this we have to change the Jenkinsfile in order to scan the 'Branch'.  With this code:

odsComponentStageScanWithSonar(context,[analyzePullRequests: false])

PS. We think that this should be the default behaviour: Not to scan PRs. Anothert option is to change all the "Quickstarters"

[michaelsauter]

I had to think a bit more about this and concluded that next to the merged solution, there is also another option. So just putting it out there as an FYI ...

Instead of disabling PR scans all the time, you could disable the CNES report only when a PR scan is performed. That should work given the issue is just with the combination of PR scan and CNES report. And it would actually be an even better approach than in 3.x because you save time by avoiding to generate the CNES report for PRs. Those reports were never used anyway, as the CNES report only makes sense for main branches.

[s2oBCN]

I had to think a bit more about this and concluded that next to the merged solution, there is also another option. So just putting it out there as an FYI ...

Instead of disabling PR scans all the time, you could disable the CNES report only when a PR scan is performed. That should work given the issue is just with the combination of PR scan and CNES report. And it would actually be an even better approach than in 3.x because you save time by avoiding to generate the CNES report for PRs. Those reports were never used anyway, as the CNES report only makes sense for main branches.

The problem is that we need the CNES repor for the LeVA documentation, and on the other hand, the PR scan is a good feature with SQ7.9, but now we have SQ8.0+

[michaelsauter]

The problem is that we need the CNES repor for the LeVA documentation

AFAIK you only use the report from the master branch, not the report from topic branches, no?

[s2oBCN]

The problem is that we need the CNES repor for the LeVA documentation

AFAIK you only use the report from the master branch, not the report from topic branches, no?

Yes, in theory, as this is configurable