Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQ integration #227

Closed
michaelsauter opened this issue Oct 5, 2021 · 0 comments · Fixed by #246
Closed

Fix SQ integration #227

michaelsauter opened this issue Oct 5, 2021 · 0 comments · Fixed by #246
Assignees
@michaelsauter
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@michaelsauter
Copy link
Member

michaelsauter commented Oct 5, 2021 •
edited

In the shared library, a few issues were noticed:

We need to check if SQ scanning in ods-pipeline is affected and fix it (with a test so that it does not break again).
@michaelsauter michaelsauter added this to the 0.2.0 milestone Oct 5, 2021
@michaelsauter michaelsauter self-assigned this Oct 8, 2021
michaelsauter added a commit that referenced this issue Oct 12, 2021
@michaelsauter
Harden SonarQube integration
dbb4f6b 
* Do not generate reports when pull request exists for scanned branch.
For more information, see
opendevstack/ods-jenkins-shared-library#663
and cnescatlab/sonar-cnes-report#159.

* Ensure background task on server finishes before generating a
report. For more information, see
opendevstack/ods-jenkins-shared-library#732.

* Unify logging approach: instead of printing to STDOUT directly for
some messages, funnel everything through the logger instance. Other
tasks should adopt this as well.

Closes #227.
michaelsauter added a commit that referenced this issue Oct 12, 2021
@michaelsauter
Harden SonarQube integration
9f0ad12 
* Do not generate reports when pull request exists for scanned branch.
For more information, see
opendevstack/ods-jenkins-shared-library#663
and cnescatlab/sonar-cnes-report#159.

* Ensure background task on server finishes before generating a
report. For more information, see
opendevstack/ods-jenkins-shared-library#732.

* Unify logging approach: instead of printing to STDOUT directly for
some messages, funnel everything through the logger instance. Other
tasks should adopt this as well.

Closes #227.
@michaelsauter michaelsauter mentioned this issue Oct 12, 2021
Merged
4 tasks
michaelsauter added a commit that referenced this issue Oct 14, 2021
@michaelsauter
Harden SonarQube integration
ce904eb 
* Do not generate reports when pull request exists for scanned branch.
For more information, see
opendevstack/ods-jenkins-shared-library#663
and cnescatlab/sonar-cnes-report#159.

* Ensure background task on server finishes before generating a
report. For more information, see
opendevstack/ods-jenkins-shared-library#732.

* Unify logging approach: instead of printing to STDOUT directly for
some messages, funnel everything through the logger instance. Other
tasks should adopt this as well.

Closes #227.
michaelsauter added a commit that referenced this issue Oct 14, 2021
@michaelsauter
Harden SonarQube integration
cae9b10 
* Do not generate reports when pull request exists for scanned branch.
For more information, see
opendevstack/ods-jenkins-shared-library#663
and cnescatlab/sonar-cnes-report#159.

* Ensure background task on server finishes before generating a
report. For more information, see
opendevstack/ods-jenkins-shared-library#732.

* Unify logging approach: instead of printing to STDOUT directly for
some messages, funnel everything through the logger instance. Other
tasks should adopt this as well.

Closes #227.
@michaelsauter michaelsauter modified the milestones: 0.2.0, 0.1.1 Oct 26, 2021
@michaelsauter michaelsauter added the bug Something isn't working label Oct 26, 2021
@michaelsauter michaelsauter changed the title Verify SQ integration Fix SQ integration Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Harden SonarQube integration opendevstack/ods-pipeline
1 participant
@michaelsauter