Harden SonarQube integration #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
force-pushed
the
fix/cnes-pr
branch
from
9f0ad12
to
ce904eb
Compare
* Do not generate reports when pull request exists for scanned branch. For more information, see opendevstack/ods-jenkins-shared-library#663 and cnescatlab/sonar-cnes-report#159. * Ensure background task on server finishes before generating a report. For more information, see opendevstack/ods-jenkins-shared-library#732. * Unify logging approach: instead of printing to STDOUT directly for some messages, funnel everything through the logger instance. Other tasks should adopt this as well. Closes #227.
michaelsauter
force-pushed
the
fix/cnes-pr
branch
from
ce904eb
to
cae9b10
Compare
cnes-report is silent on sucess.
The SQ authentication bug fixed in the previous commit was not detected because the SQ test instance allowed unauthenticated access.
Client methods should not print directly to stdout but use the logger of the client.
The typo wasn't detected as unauthenticated access to SonarQube was allowed.
|
Test failure is unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate reports when pull request exists for scanned branch.
For more information, see
Sonarqube stage crashes in cnes report ods-jenkins-shared-library#663
and Cannot generate report from Pull Request cnescatlab/sonar-cnes-report#159.
Ensure background task on server finishes before generating a
report. For more information, see
Cnes report is executed too soon in the Sonar Scanner stage ods-jenkins-shared-library#732.
Unify logging approach: instead of printing to STDOUT directly for
some messages, funnel everything through the logger instance. Other
tasks should adopt this as well.
Closes #227.
FYI @braisvq1996 based on your recent changes :)
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable