Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ods-saas-service component #607

Merged
merged 26 commits into from
Oct 25, 2021
Merged

Conversation

metmajer
Copy link
Member

@metmajer metmajer commented Mar 19, 2021

Add a new ods-saas-service component type to manage the automated documentation of external, vendor-provided services.

see: opendevstack/ods-quickstarters#556

@metmajer metmajer marked this pull request as draft March 19, 2021 20:46
@metmajer metmajer self-assigned this Mar 19, 2021
@metmajer metmajer added the enhancement New feature or request label Mar 19, 2021
@metmajer metmajer added this to To Do in OpenDevStack 4.0.0 via automation Mar 19, 2021
@@ -339,6 +340,12 @@ class MROPipelineUtil extends PipelineUtil {
} else {
this.logger.debug("Repo '${repo.id}' is of type ODS Infrastructure as Code Component/Configuration Management. Nothing to do in phase '${name}' for target environment'${targetEnvToken}'.")
}
} else if (repo.type?.toLowerCase() == PipelineConfig.REPO_TYPE_ODS_SAAS_SERVICE) {
if (this.project.isPromotionMode && name == PipelinePhases.DEPLOY) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metmajer ... i think none of this is needed... there is no jenkinsfile
. ?

Copy link
Member Author

@metmajer metmajer Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clemensutschig been thinking the same... but what if account creation, etc. is needed? Doesn't documentation suggest that there should be a Jenkinsfile?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its that way... then this needs to happen in the build phase as well.. similar to ods infra..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a minute... if we would support account creation, etc., then we would need to document this in a TIR, I guess -- which we don't want to, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a saas case Everything is done by the vendor.. so i vouch to have nothing in there.. so an empty ^if^

@clemensutschig
Copy link
Member

clemensutschig commented Sep 6, 2021

ok - I am almost thru ... we have to talk about long component names for the SSDS .. which I changed now, and which make the pdf check fail ... @metmajer

see change in: https://github.com/opendevstack/ods-jenkins-shared-library/pull/607/files#diff-704eb3b4750a51fb8baadd978345ed1f6c1d8061332e7c33855039b52234c011R93

@metmajer metmajer marked this pull request as ready for review October 13, 2021 20:15
@metmajer
Copy link
Member Author

@s2oBCN @jorge-romero some of the tests are failing in this PR. Other related PRs build fine. Please resolve the failing tests when you start working on this task.

@jorge-romero
Copy link
Contributor

jorge-romero commented Oct 20, 2021

@s2oBCN @jorge-romero some of the tests are failing in this PR. Other related PRs build fine. Please resolve the failing tests when you start working on this task.

Done, you could see a big number of new files, but they correspond to cached call to jira/docgen service to test the creation of the pdf

@clemensutschig
Copy link
Member

JUHUUU! - awesome ...

clemensutschig
clemensutschig previously approved these changes Oct 20, 2021
@metmajer
Copy link
Member Author

Nice job @jorge-romero and team :) Please don't merge yet... let this be the first thing we do after the first release of ODS 4.x and then release again. Thanks!

@s2oBCN s2oBCN merged commit 737562b into master Oct 25, 2021
OpenDevStack 4.0.0 automation moved this from In Progress to Done Oct 25, 2021
@s2oBCN s2oBCN deleted the feature/add-ods-saas-service-component branch October 25, 2021 15:07
s2oBCN pushed a commit that referenced this pull request Nov 4, 2021
* Integrate ods-saas-service component type

(cherry picked from commit 737562b)
s2oBCN added a commit that referenced this pull request Nov 5, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN added a commit that referenced this pull request Nov 30, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN added a commit that referenced this pull request Dec 1, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants