Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document history in cftp #707

Merged
merged 7 commits into from
Sep 30, 2021
Merged

Conversation

jorge-romero
Copy link
Contributor

Remove not needed entries in the document history of the document cftp

@metmajer
Copy link
Member

metmajer commented Aug 6, 2021

@jorge-romero what is the purpose of this PR? The FTP needs to list all test cases. This change removes the references to the test cases and therefore they will not be printed in the FTP document.

@metmajer metmajer marked this pull request as draft August 6, 2021 20:24
@jorge-romero
Copy link
Contributor Author

@jorge-romero what is the purpose of this PR? The FTP needs to list all test cases. This change removes the references to the test cases and therefore they will not be printed in the FTP document.

@metmajer Currently CFTP only has descriptive information that is obtained of the Documentation Chapters. The test cases exists in the CFTR document, with this changes we remove the not needed information regarding tests in json, that includes the information in the data area and the history area of the method output.

@jorge-romero
Copy link
Contributor Author

@metmajer Confirmed the last coment, it is not needed to add the references of the tests, this document works as a test strategy, not a test plan

@metmajer
Copy link
Member

@jorge-romero please resolve conflicts and I will approve.

@jorge-romero jorge-romero marked this pull request as ready for review September 30, 2021 12:02
@jorge-romero jorge-romero merged commit d277c43 into master Sep 30, 2021
@metmajer
Copy link
Member

@s2oBCN @jorge-romero please also merge into 4.x

jorge-romero added a commit that referenced this pull request Oct 1, 2021
remove issues that does not belongs to the cftp document
s2oBCN added a commit that referenced this pull request Nov 5, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN added a commit that referenced this pull request Nov 30, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN added a commit that referenced this pull request Dec 1, 2021
* Fix document history in cftp (#707)

remove issues that does not belongs to the cftp document

* by default analyzePullRequests should be false (#731)

* by default analyzePullRequests should be false

* Fix/ra matrix table fit in page 4x (#735)

Add method to convert to nonbreakable unicode charater

* add check for Sonar background task with retry

* add typecheck skip

* move retry to function

* fix text and add check for unknown status

* add examples for the new api and file used

* fix CodeNarc violations

* fix tests

* fix tests, move getTaskResult to service

* update changelog

* When two coded tests are linked to the same test issue the… (#737)

[EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails

* [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741)

* [EDPC-993] The Developer Preview fails because "Duplicated Tests"

- Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results
- Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results
- In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false
  to avoid to check duplications in test results

* Feature/improve functiona testing (#743)

* update date_creation in wiremock files

* Add ods-saas-service component (#607)

* Integrate ods-saas-service component type

* Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744)

* Added getVersion

* Updated changelog

(cherry picked from commit f1ea9b7)

* Fix/remove from tip non intalled components (#751)

* Remove from TIP non installed components

(cherry picked from commit 8ddf143)

Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com>
Co-authored-by: braisvq1996 <bvq1996@gmail.com>
Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com>
Co-authored-by: Angel MP <angelmp.mail@gmail.com>
Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants