Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemensutschig
previously approved these changes
Oct 22, 2021
|
This is still hugely inefficient - because we do this in every doc (and hence for the same referenced doc n-times) .. is this something you folks go after? @hrcornejo @metmajer |
angelmp01
reviewed
Oct 22, 2021
@clemensutschig , @jafarre-viewnext is working in parallel on ticket EDPC-736 to reduce the outbound calls and improve the performance of this code. |
clemensutschig
approved these changes
Oct 26, 2021
s2oBCN
added a commit
that referenced
this pull request
Nov 5, 2021
* Fix document history in cftp (#707) remove issues that does not belongs to the cftp document * by default analyzePullRequests should be false (#731) * by default analyzePullRequests should be false * Fix/ra matrix table fit in page 4x (#735) Add method to convert to nonbreakable unicode charater * add check for Sonar background task with retry * add typecheck skip * move retry to function * fix text and add check for unknown status * add examples for the new api and file used * fix CodeNarc violations * fix tests * fix tests, move getTaskResult to service * update changelog * When two coded tests are linked to the same test issue the… (#737) [EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails * [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741) * [EDPC-993] The Developer Preview fails because "Duplicated Tests" - Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results - Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results - In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false to avoid to check duplications in test results * Feature/improve functiona testing (#743) * update date_creation in wiremock files * Add ods-saas-service component (#607) * Integrate ods-saas-service component type * Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744) * Added getVersion * Updated changelog (cherry picked from commit f1ea9b7) * Fix/remove from tip non intalled components (#751) * Remove from TIP non installed components (cherry picked from commit 8ddf143) Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: braisvq1996 <bvq1996@gmail.com> Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com> Co-authored-by: Angel MP <angelmp.mail@gmail.com> Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com> Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN
added a commit
that referenced
this pull request
Nov 30, 2021
* Fix document history in cftp (#707) remove issues that does not belongs to the cftp document * by default analyzePullRequests should be false (#731) * by default analyzePullRequests should be false * Fix/ra matrix table fit in page 4x (#735) Add method to convert to nonbreakable unicode charater * add check for Sonar background task with retry * add typecheck skip * move retry to function * fix text and add check for unknown status * add examples for the new api and file used * fix CodeNarc violations * fix tests * fix tests, move getTaskResult to service * update changelog * When two coded tests are linked to the same test issue the… (#737) [EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails * [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741) * [EDPC-993] The Developer Preview fails because "Duplicated Tests" - Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results - Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results - In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false to avoid to check duplications in test results * Feature/improve functiona testing (#743) * update date_creation in wiremock files * Add ods-saas-service component (#607) * Integrate ods-saas-service component type * Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744) * Added getVersion * Updated changelog (cherry picked from commit f1ea9b7) * Fix/remove from tip non intalled components (#751) * Remove from TIP non installed components (cherry picked from commit 8ddf143) Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: braisvq1996 <bvq1996@gmail.com> Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com> Co-authored-by: Angel MP <angelmp.mail@gmail.com> Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com> Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
s2oBCN
added a commit
that referenced
this pull request
Dec 1, 2021
* Fix document history in cftp (#707) remove issues that does not belongs to the cftp document * by default analyzePullRequests should be false (#731) * by default analyzePullRequests should be false * Fix/ra matrix table fit in page 4x (#735) Add method to convert to nonbreakable unicode charater * add check for Sonar background task with retry * add typecheck skip * move retry to function * fix text and add check for unknown status * add examples for the new api and file used * fix CodeNarc violations * fix tests * fix tests, move getTaskResult to service * update changelog * When two coded tests are linked to the same test issue the… (#737) [EDPC-350] When two coded tests are linked to the same test issue the pipeline doesn't fails * [EDPC-993] The Developer Preview fails because "Duplicated Tests" (#741) * [EDPC-993] The Developer Preview fails because "Duplicated Tests" - Added param checkDuplicateTestResults in computeTestDiscrepancies to check or not the duplicate tests results - Added param checkDuplicateTestResults in matchTestIssuesAgainstTestResults to check or not the duplicate tests results - In the creation of the documents TRC and CFTR the call to computeTestDiscrepancies method is with the param matchTestIssuesAgainstTestResults=false to avoid to check duplications in test results * Feature/improve functiona testing (#743) * update date_creation in wiremock files * Add ods-saas-service component (#607) * Integrate ods-saas-service component type * Refactor and create unit test for LeVADocumentUseCase.getReferencedDocumentsVersion (#744) * Added getVersion * Updated changelog (cherry picked from commit f1ea9b7) * Fix/remove from tip non intalled components (#751) * Remove from TIP non installed components (cherry picked from commit 8ddf143) Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: braisvq1996 <bvq1996@gmail.com> Co-authored-by: Michael Sauter <michael.sauter@boehringer-ingelheim.com> Co-authored-by: Angel MP <angelmp.mail@gmail.com> Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com> Co-authored-by: Hector Rodriguez Cornejo <hrcornejo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.