Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor u8 support #55

Closed
andimik opened this issue Mar 3, 2024 · 5 comments
Closed

Poor u8 support #55

andimik opened this issue Mar 3, 2024 · 5 comments

Comments

@andimik
Copy link
Contributor

andimik commented Mar 3, 2024

The actual version ODR-DabMod version v2.6.0-69 ( g029e9c7 ) has a very bad u8 support. Even with very sensitive AbracaDABra I get only 4.9 dB and poor audio.

grafik

Then I went back to a former installation, ODR-DabMod version v2.6.0-1 (g12f6daf), 12f6daf

Much better, 31 dB

grafik

It's both times the same command.

$ cat ./foo.eti | odr-dabmod /dev/stdin -f /tmp/foo.raw -F u8

@mpbraendli
Copy link
Member

Interesting observation? Are you able to narrow it down to the commit that changes this behaviour?

@andimik
Copy link
Contributor Author

andimik commented Mar 7, 2024

Yes, but only when I find some time. In the meantime I will use the old one.

@andimik
Copy link
Contributor Author

andimik commented Mar 7, 2024

But this is the difference (I even did not know it's so easy to compare two commits):

https://github.com/opendigitalradio/ODR-DabMod/compare/029e9c7..12f6daf#diff-4634e877086bf0dad2d6bede99eb945ff1b0dd381662d8dda7b5afb56ee99dcb

check formatconverter.cpp and the for and else , but I have no idea what it means.

mpbraendli added a commit that referenced this issue Mar 11, 2024
@mpbraendli
Copy link
Member

Thanks for notifying me about this, and for your analysis. Can you try latest 'next' ?

@andimik
Copy link
Contributor Author

andimik commented Mar 11, 2024

Yes, that 03bf901 fixed the issue :-)

grafik

$ cat ./nrk1.eti | odr-dabmod /dev/stdin -f /tmp/nrk1.raw -F u8
ODR-DabMod version v2.6.0-71-g03bf901, compiled at Mar 11 2024, 20:54:28
Compiled with features: zeromq output_soapysdr SSE 
Input
  Type: file
  Source: /dev/stdin
Output
  Name: /tmp/nrk1.raw
  Sampling rate: 2.0480 MHz

grafik

@andimik andimik closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants