Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ooo): add deprecated function decorator #778

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Mar 5, 2024

Description

Add deprecated function decorator

Related Issue

#621

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (e28438c) to head (df70a6d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   75.87%   75.85%   -0.03%     
==========================================
  Files         679      681       +2     
  Lines       55249    55186      -63     
==========================================
- Hits        41920    41860      -60     
+ Misses      13329    13326       -3     
Flag Coverage Δ
unittests 75.85% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaParaZz1 PaParaZz1 changed the title feature: Add deprecated function decorator feature(ooo): add deprecated function decorator Mar 6, 2024
Copy link
Member

@PaParaZz1 PaParaZz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please modify this PR according to our review comments, then we will merge this PR.

ding/utils/deprecation.py Outdated Show resolved Hide resolved
ding/utils/deprecation.py Outdated Show resolved Hide resolved
ding/utils/deprecation.py Show resolved Hide resolved
ding/utils/deprecation.py Outdated Show resolved Hide resolved
ding/utils/deprecation.py Show resolved Hide resolved
@ooooo-create
Copy link
Contributor Author

I have modifed pr.

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Mar 7, 2024
Copy link
Member

@PaParaZz1 PaParaZz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution again! Now we will merge this PR.

@PaParaZz1 PaParaZz1 merged commit 0591b5e into opendilab:main Mar 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants