This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Backport workbench fixes to 7.9.1 #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error messages for `Explain` aside from empty box. More detail in error messages for invalid queries on `Run`
…elasticsearch#869) * Fix download link in package description (opendistro-for-elasticsearch#729) * remove logo for side bar Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Yuanqi Zhu <zhyuanqi@amazon.com>
…lasticsearch#890) * removed key "id" from result table * removed cache files from PR * remove unnecessary lines * fixed search bar * update * update * update * update * update Co-authored-by: Joshua <joshuali925@gmail.com>
…icsearch#886) * Fix download json api path * Fix cypress tests * Fix response tab margin * Update cypress tests * Fix server log message * Fix asScoped call for security plugin * Update cypress tests * Fix unique keys problem * Remove console log
* Disable sorting on workbench * Address comments
…rch#911) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
penghuo
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## opendistro-1.11-rc2 #937 +/- ##
======================================================
Coverage 99.86% 99.86%
Complexity 2320 2320
======================================================
Files 230 230
Lines 5337 5337
Branches 346 346
======================================================
Hits 5330 5330
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
joshuali925
approved these changes
Dec 15, 2020
| @@ -42,32 +42,32 @@ export const testQueries = [ | |||
| { | |||
| title: 'Test GROUP BY', | |||
| query: 'select count(*) from accounts group by gender;', | |||
| cell_idx: 5, | |||
There was a problem hiding this comment.
np/question: what's the reason for the value changes here?
There was a problem hiding this comment.
id column was removed and the cell index shifted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.