Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

[WIP] adds kubernetes docs and resources #59

Closed
wants to merge 1 commit into from

Conversation

vniche
Copy link

@vniche vniche commented Apr 17, 2019

*Issue #49 *

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It still lacks custom config files and certificate usage guide, that's why of the WIP.

Copy link
Contributor

@aetter aetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the work here! I think it's a really good start. I'm going on vacation at end of week, but I'll check out any new content when I get back. Just let me know when you're happy with it and I'll do a more comprehensive review with, like, actual testing. :)

layout: default
title: Kubernetes
parent: Install and Configure
nav_order: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is should be either 5 (if you expect it to be standalone forever) or 10 (if you suspect the need for more pages on Kubernetes).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting a separate page for Security settings, like Custom Users & Roles and Certificates, seems more ease on beginners, since with the current manifests users can already have a up and running installation.


## Important settings

For production workloads, make sure to set [Docker's](https://stackoverflow.com/questions/45165178/changing-ulimit-value-in-docker-run-command) `nofile` to `65535`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I discourage linking to QA sites, as there's often a lack of context around the question. Can we summarize the reasoning here?

Copy link
Author

@vniche vniche Apr 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's a prerequisite since Elasticsearch doesn't even start without the right sizing of this config, i'll try to find the official page for this, i bet there is.

@@ -0,0 +1,55 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know both are fine, but yml for the file extension is generally what Elasticsearch uses.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a Elasticsearch resource, and personally i don't think yml is fine, but a lazy abbreviation of well-defined extension:

1. Is there an official extension for YAML files?

Please use ".yaml" when possible.

font: https://yaml.org/faq.html

About Elasticsearch resource files there's nothing i can do, but for others i can at least advocate.

@@ -0,0 +1,114 @@
# based on https://www.digitalocean.com/community/tutorials/how-to-set-up-an-elasticsearch-fluentd-and-kibana-efk-logging-stack-on-kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know both are fine, but yml for the file extension is generally what Elasticsearch uses.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a Elasticsearch resource, and personally i don't think yml is fine, but a lazy abbreviation of well-defined extension:

1. Is there an official extension for YAML files?

Please use ".yaml" when possible.

font: https://yaml.org/faq.html

About Elasticsearch resource files there's nothing i can do, but for others i can at least advocate.

@aetter
Copy link
Contributor

aetter commented Jan 21, 2020

Given its age and that we now have https://opendistro.github.io/for-elasticsearch-docs/docs/install/helm/, I'm going to close this out, but I suspect some of the content from this PR could still be integrated into that page. If you'd like to open another PR with additions or a more structural changes, we'd love to review them.

@aetter aetter closed this Jan 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants