Polars: add make_with_columns
#824
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
Merged
Closed
Merged
Shoeboxam
requested changes
Jun 22, 2023
|
|
||
| use super::*; | ||
|
|
||
| fn get_3_row_test_data() -> (LazyFrameDomain, LazyFrame, ExprDomain) { |
There was a problem hiding this comment.
Similar comment as in the other PR, make this return a Fallible so you can replace the .unwrap_test()s with ?.
There was a problem hiding this comment.
Do you think these test data helper functions could be reused? If so, move them out into a #[cfg(test)] module in rust/src/transformations/polars/mod.rs (and mark the functions as pub so you can use it from these tests).
Shoeboxam
reviewed
Jun 22, 2023
ankke
force-pushed
the
821-make-select-trans
branch
2 times, most recently
from
5ed95ed
to
bb405ea
Compare
ankke
force-pushed
the
821-make-select-trans
branch
from
bb405ea
to
9cdfeaf
Compare
ankke
force-pushed
the
821-make-select-trans
branch
from
9cdfeaf
to
8e05b11
Compare
ankke
force-pushed
the
821-make-select-trans
branch
from
8e05b11
to
995af02
Compare
ankke
force-pushed
the
821-make-select-trans
branch
from
995af02
to
92c3c0a
Compare
Shoeboxam
force-pushed
the
make-cal
branch
2 times, most recently
from
716c969
to
18c7eb4
Compare
Shoeboxam
force-pushed
the
821-make-select-trans
branch
from
92c3c0a
to
af414d8
Compare
Shoeboxam
force-pushed
the
make-cal
branch
10 times, most recently
from
bb423fc
to
f83e71e
Compare
This was referenced Apr 15, 2024
Shoeboxam
force-pushed
the
make-cal
branch
3 times, most recently
from
9e375ab
to
5200178
Compare
Shoeboxam
force-pushed
the
make-cal
branch
3 times, most recently
from
99fab60
to
807cad5
Compare
Shoeboxam
force-pushed
the
make-cal
branch
3 times, most recently
from
72e0a4f
to
9aed08e
Compare
This was referenced Apr 25, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.