-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use ffiresult in monomorphize functions #921
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Shoeboxam and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little tricky, but I think it's still a solid overall improvement. Moving to proc macros is still an option in the future to resolve remaining issues.
c56f149
to
a258e30
Compare
903f1bb
to
013294b
Compare
a258e30
to
9f4a4c0
Compare
013294b
to
df8e445
Compare
9f4a4c0
to
b77e847
Compare
df8e445
to
a705387
Compare
b77e847
to
984b5e2
Compare
a705387
to
b79a597
Compare
Through the process of writing this, I've become more unsure about switching these. On one hand, it's nice to be able to try, but on the other hand,
Alternatively, it may not matter-- as the proc macro could simply enclose the dispatch in a closure.