Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use ffiresult in monomorphize functions #921

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

Shoeboxam
Copy link
Member

@Shoeboxam Shoeboxam commented Aug 11, 2023

Through the process of writing this, I've become more unsure about switching these. On one hand, it's nice to be able to try, but on the other hand,

  • the error handling is now inconsistent with the root code
  • the macro-based error handling is easier to use with proc-macro-generated dispatch, should we change our dispatch to it

Alternatively, it may not matter-- as the proc macro could simply enclose the dispatch in a closure.

andrewvyrros
andrewvyrros previously approved these changes Oct 10, 2023
Copy link
Member

@andrewvyrros andrewvyrros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little tricky, but I think it's still a solid overall improvement. Moving to proc macros is still an option in the future to resolve remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

don't return FfiResults in monomorphize functions
2 participants