Polars: lazyframe_domain ffi

[Shoeboxam]

Closes #768

[Shoeboxam]

• Polars: lazyframe_domain ffi #769 : 2 dependent PRs (#771 , #1167 ) 👈
• Polars: series_domain ffi #767
• Polars: add FrameDomain #765
• Polars: add SeriesDomain #763
• tweak FFI traits for more helpful compile errors #917 : 1 other dependent PR (#921 )
• fallible MetricSpace check #916
• user-friendly downcast-ref error message #907
• support multithreading #874
• make_base_discrete_exponential proof #705
• add make_base_discrete_exponential ffi #754
• add make_base_discrete_exponential #704
• make_quantile_score_candidates proof #703
• add make_quantile_score_candidates ffi #753
• add make_quantile_score_candidates #702
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Shoeboxam and the rest of your teammates on Graphite

[mccalluc]

If the python types also work, it'd be good to test them. If they don't, I'd worry about usability -- Not necessarily something to address now, but a comment pointing to an issue would be good if it's not something for right now.

[Shoeboxam]

An annoying aspect is that Polars defaults to i64, but the default inferred type of int is i32. So if you don't specify the types exactly, then the domains will each expect i32 but the data (a few lines below) is actually i64.

[mccalluc]

Thanks for the explanation. It would be easy for users to get this wrong, so if we can't get around this, maybe just a test to make sure the error message is readable. I'll file a little issue for this.

• Filed Check error message if int type mismatch between polars and domain #1504

[mccalluc]

This corresponds to this test helper?

def _with_margin(domain, by):
    return dp.with_margin(domain, by=by, public_info="lengths", max_partition_size=50)

I feel weird about passing in strings when we really just need to convey a boolean.

Also: It looks like "lengths" is exercised in the tests. Should we have some coverage for "keys"?

[Shoeboxam]

There's actually three states: no public info, known keys, and known lengths. I think the stringly-typed argument is clearer. An enum would be best, but I don't have FFI for it.

[Shoeboxam]

Added another test for initializing with keys.

[mccalluc]

Thanks. Changes look good.

[mccalluc]

Thanks for the explanation. It would be easy for users to get this wrong, so if we can't get around this, maybe just a test to make sure the error message is readable. I'll file a little issue for this.

• Filed Check error message if int type mismatch between polars and domain #1504

The base branch was changed.