Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.py #24

Closed
wants to merge 1 commit into from
Closed

Update plugin.py #24

wants to merge 1 commit into from

Conversation

PD1LOI
Copy link

@PD1LOI PD1LOI commented Oct 6, 2019

Font adjustment for HD 1920x1080

Font adjustment for HD 1920x1080
@drecomx
Copy link
Contributor

drecomx commented Oct 6, 2019

What's the reason you want to increase font size from 30 to 32? Especially given that the itemheight is 90 this would end up in ugly results on the screen (90/32 --> 2.81 lines).

@drecomx drecomx closed this Oct 6, 2019
@PD1LOI
Copy link
Author

PD1LOI commented Oct 6, 2019 via email

@drecomx
Copy link
Contributor

drecomx commented Oct 6, 2019

I don't see any picture. But again: your update is not considering the item height which will end up in parts of the text being invisible. Provide a proper change that considers everything and I'll merge it but your pull request is not complete.

@PD1LOI
Copy link
Author

PD1LOI commented Oct 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants