Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一些公共的类是不是过于重复 #2

Closed
zypy333 opened this issue Nov 24, 2023 · 2 comments
Closed

一些公共的类是不是过于重复 #2

zypy333 opened this issue Nov 24, 2023 · 2 comments

Comments

@zypy333
Copy link

zypy333 commented Nov 24, 2023

各个包里都有GroupProxy 类似的类,是不是可以抽成一个基类,用多态比较方便做不同版本切换,改错误也容易一些

另外
GroupProxy里的103行 参数不一致
checkMessages.putMessage(record.Index, String.format("%s->%s %s",x,zd));
130行 转码了两遍

status=trans(record);  
            if (trans(record)!=null){
@OpenDRG
Copy link
Owner

OpenDRG commented Feb 16, 2024

你好,我的设计思路,每一个地区的分组器是完全独立的,他们会编译打包成独立的可执行文件,如dll,jar等,版本切换时,更换这些文件即可。而不需要在GroupProxy层面进行复用

@OpenDRG
Copy link
Owner

OpenDRG commented Feb 16, 2024

你提到的两处错误,请给出具体的路径和文件,我来修正

@OpenDRG OpenDRG closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants