fix(VERSION): remove version dependency during volume provisioning #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following changes
- Removes the dependency with CVC Version during volume
provisioing.
- Updates the VERSION variable with ${CURRENT_BRANCH_NAME}-dev
during build time
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 7 7
Lines 335 335
=======================================
Hits 214 214
Misses 108 108
Partials 13 13 Continue to review full report at Codecov.
|
mittachaitu
pushed a commit
to mittachaitu/cstor-csi
that referenced
this pull request
Jun 29, 2020
…enebs-archive#97) This PR does the following changes - Removes the dependency with CVC Version during volume provisioing. - Updates the VERSION variable with ${CURRENT_BRANCH_NAME}-dev during build time Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
What this PR does:
This PR does the following changes
provisioning.
during build time
Why we need this PR:
This PR is required to break the dependency with CVC-Operator
during volume provisioning. Below are the existing steps performed
during volume provisioning:
cvc.VersionDetails.Status.Currentmatches to VERSION value in CVC controller. If reconciliation doesn't happen then
CStorVolume resources will not create hence the application will not get OpenEBS volume.
Which issue(s) this PR fixes:
Fixes # openebs-archive/cstor-operators#108
Special notes for your reviewer:
Checklist
documentationtagrequires-upgradetag