Skip to content
This repository has been archived by the owner on Jun 9, 2020. It is now read-only.

Fix for Issue #20 #21

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Fix for Issue #20 #21

merged 1 commit into from
Oct 19, 2017

Conversation

ksatchit
Copy link

@ksatchit ksatchit commented Oct 17, 2017

Code Changes :

  • The setup-test-images role creates separate tar file for each test image suffixed with image version
  • The load-test-images role loads the images from above individual tarfiles
  • Changes in logic to detect presence of image tar files in "files" folder of load-test-images role
  • Reverts an additional global variable introduced in Placeholder for roles & playbooks to address OpenEBS issue #463 #19

Fixes #20

Output :

22:52:23 TASK [Check for presence of tarfiles] ******************************************

22:52:23 task path: /var/lib/[*******]/openebs/e2e/ansible/load-images.yml:5
22:52:23 changed: [kubeminion02 -> 127.0.0.1] => {"changed": true, "cmd": "ls *.tar", "delta": "0:00:00.012725", "end": "2017-10-17 22:52:23.685181", "rc": 0, "start": "2017-10-17 22:52:23.672456", "stderr": "", "stderr_lines": [], "stdout": "jupyter_v0.4.tar\nmysqlclient_latest.tar\npercona_latest.tar\npostgres_centos7-9.6-1.4.0.tar", "stdout_lines": ["jupyter_v0.4.tar", "mysqlclient_latest.tar", "percona_latest.tar", "postgres_centos7-9.6-1.4.0.tar"]}
22:52:23 changed: [kubeminion01 -> 127.0.0.1] => {"changed": true, "cmd": "ls *.tar", "delta": "0:00:00.013118", "end": "2017-10-17 22:52:23.685862", "rc": 0, "start": "2017-10-17 22:52:23.672744", "stderr": "", "stderr_lines": [], "stdout": "jupyter_v0.4.tar\nmysqlclient_latest.tar\npercona_latest.tar\npostgres_centos7-9.6-1.4.0.tar", "stdout_lines": ["jupyter_v0.4.tar", "mysqlclient_latest.tar", "percona_latest.tar", "postgres_centos7-9.6-1.4.0.tar"]}
22:52:23 TASK [load-test-images : Load test images from Archive] ************************

22:52:23 task path: /var/lib/[*******]/openebs/e2e/ansible/roles/load-test-images/tasks/main.yml:4
22:52:52 changed: [kubeminion02] => (item={u'image': u'percona', u'tag': u'latest', u'label': u'percona'}) => {"changed": true, "cmd": ["docker", "load", "--input", "percona_latest.tar"], "delta": "0:00:28.714774", "end": "2017-10-17 17:22:50.984342", "item": {"image": "percona", "label": "percona", "tag": "latest"}, "rc": 0, "start": "2017-10-17 17:22:22.269568", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:52:55 changed: [kubeminion01] => (item={u'image': u'percona', u'tag': u'latest', u'label': u'percona'}) => {"changed": true, "cmd": ["docker", "load", "--input", "percona_latest.tar"], "delta": "0:00:31.361782", "end": "2017-10-17 17:22:53.516901", "item": {"image": "percona", "label": "percona", "tag": "latest"}, "rc": 0, "start": "2017-10-17 17:22:22.155119", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:55:33 changed: [kubeminion02] => (item={u'image': u'satyamz/docker-jupyter', u'tag': u'v0.4', u'label': u'jupyter'}) => {"changed": true, "cmd": ["docker", "load", "--input", "jupyter_v0.4.tar"], "delta": "0:02:39.689797", "end": "2017-10-17 17:25:30.993924", "item": {"image": "satyamz/docker-jupyter", "label": "jupyter", "tag": "v0.4"}, "rc": 0, "start": "2017-10-17 17:22:51.304127", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:55:35 changed: [kubeminion01] => (item={u'image': u'satyamz/docker-jupyter', u'tag': u'v0.4', u'label': u'jupyter'}) => {"changed": true, "cmd": ["docker", "load", "--input", "jupyter_v0.4.tar"], "delta": "0:02:39.282934", "end": "2017-10-17 17:25:33.124406", "item": {"image": "satyamz/docker-jupyter", "label": "jupyter", "tag": "v0.4"}, "rc": 0, "start": "2017-10-17 17:22:53.841472", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:56:27 changed: [kubeminion02] => (item={u'image': u'crunchydata/crunchy-postgres', u'tag': u'centos7-9.6-1.4.0', u'label': u'postgres'}) => {"changed": true, "cmd": ["docker", "load", "--input", "postgres_centos7-9.6-1.4.0.tar"], "delta": "0:00:53.512844", "end": "2017-10-17 17:26:25.485193", "item": {"image": "crunchydata/crunchy-postgres", "label": "postgres", "tag": "centos7-9.6-1.4.0"}, "rc": 0, "start": "2017-10-17 17:25:31.972349", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:56:27 changed: [kubeminion01] => (item={u'image': u'crunchydata/crunchy-postgres', u'tag': u'centos7-9.6-1.4.0', u'label': u'postgres'}) => {"changed": true, "cmd": ["docker", "load", "--input", "postgres_centos7-9.6-1.4.0.tar"], "delta": "0:00:51.848396", "end": "2017-10-17 17:26:25.526085", "item": {"image": "crunchydata/crunchy-postgres", "label": "postgres", "tag": "centos7-9.6-1.4.0"}, "rc": 0, "start": "2017-10-17 17:25:33.677689", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:56:35 changed: [kubeminion01] => (item={u'image': u'openebs/tests-mysql-client', u'tag': u'latest', u'label': u'mysqlclient'}) => {"changed": true, "cmd": ["docker", "load", "--input", "mysqlclient_latest.tar"], "delta": "0:00:07.571146", "end": "2017-10-17 17:26:33.352870", "item": {"image": "openebs/tests-mysql-client", "label": "mysqlclient", "tag": "latest"}, "rc": 0, "start": "2017-10-17 17:26:25.781724", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
22:56:35 changed: [kubeminion02] => (item={u'image': u'openebs/tests-mysql-client', u'tag': u'latest', u'label': u'mysqlclient'}) => {"changed": true, "cmd": ["docker", "load", "--input", "mysqlclient_latest.tar"], "delta": "0:00:07.837105", "end": "2017-10-17 17:26:33.654025", "item": {"image": "openebs/tests-mysql-client", "label": "mysqlclient", "tag": "latest"}, "rc": 0, "start": "2017-10-17 17:26:25.816920", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

-----------------

- The setup-test-images role creates separate tarfile for each test image
  suffixed with image version

- The load-test-images role loads the images from above individual tarfiles

- Changes in logic to detect presence of image tarfiles in files folder of
  load-test-images

- Reverts an additional global variable introduced in #19
Copy link
Contributor

@yudaykiran yudaykiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain version-based image tarfiles for pre-pull before tests (Refer PR 19)
2 participants