(fix): add support for OpenEBS local PVs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ksatchit <karthik.s@mayadata.io>
ksatchit
changed the title
Signed-off-by: ksatchit <karthik.s@mayadata.io>
kmova
reviewed
May 12, 2020
| @@ -51,7 +55,7 @@ function collect_pv_utilization_metrics(){ | |||
|
|
|||
| for i in ${pv_list[@]} | |||
| do | |||
| pv_mount_list+=($(df -h | grep ${i} | awk '{print $NF}')) | |||
| pv_mount_list+=($(findmnt --df | grep ${i} | grep '/var/lib/kubelet/pods' | head -1 | awk '{print $NF}')) | |||
There was a problem hiding this comment.
Just thinking out loud, the path can be varying depending on the K8s distribution.
For example, in RKE, the path is /opt/rke/var/lib/kubelet/pods, this code will work even for RKE as the match is available. However, would it still be better to make this configurable via ENV? Maybe a future PR?
kmova
approved these changes
May 12, 2020
slalwani97
reviewed
May 12, 2020
slalwani97
approved these changes
May 13, 2020
Signed-off-by: ksatchit <karthik.s@mayadata.io>
kmova
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR consists of some small improvements to the existing monitor-pv bash script.
Uses
findmnt --dfas a way to determine PV mount points over usingdf. The local PV mounts do not show up in case of the latter. Findmnt has a broader reach, i.e., looks for filesystems in/etc/mtab,/etc/fstab&/proc/self/mountinfoby default. the--dfflag (outputs in similar format as df) has been used to enable simpler command output parse.The mount points for a given PV are filtered to the one in this path
var/lib/kubelet/podsas this is the constant in a list of several mounts (including those depending on PV type and Cluster type. For example,/var/lib/kubelet/plugins/,/home/kubernetes/containerized_mounter/)Fixes the command to obtain volume capacity in bytes
cutdoesn't accept multi-character delimiter, sotris used insteadAdds a sample deployment spec that uses openebs namespace and serviceaccount.
Signed-off-by: ksatchit karthik.s@mayadata.io