Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Adding test for local_hostpath.go #122

Merged
merged 1 commit into from
Oct 2, 2021
Merged

test: Adding test for local_hostpath.go #122

merged 1 commit into from
Oct 2, 2021

Conversation

giovannitgl
Copy link
Contributor

Added testing for local_hostpath issue #121

@giovannitgl giovannitgl mentioned this pull request Oct 1, 2021
Closed
@Abhishek-kumar09
Copy link
Contributor

cc @vharsh

@vharsh vharsh self-requested a review October 2, 2021 06:30
vharsh
vharsh approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vharsh
Copy link
Member

vharsh commented Oct 2, 2021

Thanks @giovannitgl for contributing to OpenEBS. 🥳

@vharsh vharsh merged commit 3080795 into openebs:develop Oct 2, 2021
@vharsh vharsh linked an issue Oct 3, 2021 that may be closed by this pull request
Add unit tests functions in pkg/volume/local_hostpath.go #121
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vharsh vharsh vharsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests functions in pkg/volume/local_hostpath.go
3 participants
@giovannitgl @Abhishek-kumar09 @vharsh