add contributing checkout list #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wiwen <shenggxhz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 22.90% 22.90%
=======================================
Files 14 14
Lines 489 489
=======================================
Hits 112 112
Misses 376 376
Partials 1 1 Continue to review full report at Codecov.
|
pawanpraka1
reviewed
May 29, 2020
CONTRIBUTING.md
Outdated
| - Pass the compile and tests - includes spell checks, formatting, etc. | ||
| - Commit header (first line) should convey what changed and it should follow the commit [guideline](https://github.com/openebs/openebs/blob/master/contribute/git-commit-message.md) | ||
| - Commit body should include details such as why the changes are required and how the proposed changes help | ||
| - DCO Signed | ||
| - DCO Signed | ||
| * if you have changed crd(comment or anything), then run make manifests to generate the crds as they are auto generated. So you need to do two things: |
There was a problem hiding this comment.
can we remove this line and append make manifests with make format in the above line (line 29).
Before committing your code, make sure you have run make format and make manifests, to format the code and autogenerate the CRDs yaml.
pawanpraka1
reviewed
May 29, 2020
Signed-off-by: wiwen <shenggxhz@gmail.com>
fix it and doned. when the two pr can be merged? |
pawanpraka1
added
Need community involvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the contrubuting document，add make format document to the contrubuting document.