Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mount): moving to legacy mount #151

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

Signed-off-by: Pawan pawan@mayadata.io

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

We can not mount the datasets to more than one path via zfs mount command, shifting to the legacy way of handling ZFS volumes where we can mount/umount the datasets via legacy mount and umount commands.

This will also add a building block for SINGLE-NODE-MULTI-WRITER Capability.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on

@pawanpraka1 pawanpraka1 added enhancement Add new functionality to existing feature pr/hold-review hold the review. pr/hold-merge hold the merge. labels Jun 8, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone Jun 8, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova June 8, 2020 11:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #151 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   22.90%   22.71%   -0.19%     
==========================================
  Files          14       14              
  Lines         489      493       +4     
==========================================
  Hits          112      112              
- Misses        376      380       +4     
  Partials        1        1              
Impacted Files Coverage Δ
pkg/usage/usage.go 0.00% <0.00%> (ø)
pkg/usage/googleanalytics.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e558bb5...e0f1125. Read the comment docs.

@pawanpraka1 pawanpraka1 removed pr/hold-merge hold the merge. pr/hold-review hold the review. labels Jun 8, 2020
@pawanpraka1 pawanpraka1 force-pushed the mount branch 3 times, most recently from b0cb873 to e193069 Compare June 8, 2020 15:30
pkg/zfs/mount.go Show resolved Hide resolved
We can not mount the datasets to more than one path via zfs mount command,
shifting to the legacy way of handling ZFS volumes where we can mount/umount
the datasets via legacy mount and umount commands.

This will also add a building block for SINGLE-NODE-MULTI-WRITER Capability.

Signed-off-by: Pawan <pawan@mayadata.io>
@kmova kmova merged commit 639ead4 into openebs:master Jun 9, 2020
@pawanpraka1 pawanpraka1 deleted the mount branch June 9, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants