Cross Build enviroment bug fixes #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
======================================
Coverage 1.11% 1.11%
======================================
Files 11 11
Lines 899 899
======================================
Hits 10 10
Misses 889 889
Continue to review full report at Codecov.
|
Signed-off-by: praveengt <praveen.gt@flipkart.com>
Signed-off-by: praveengt <praveen.gt@flipkart.com>
praveengt
changed the title
Signed-off-by: praveengt <praveen.gt@flipkart.com>
pawanpraka1
approved these changes
Dec 21, 2020
pawanpraka1
pushed a commit
that referenced
this pull request
Dec 21, 2020
- Adding typecasting to make compilation work under MAC build environment - Using go env variable instead of uname for determining platform Signed-off-by: praveengt <praveen.gt@flipkart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Adding Typecasting as Bsize is different type in different environment
What this PR does?:
Just adds type cast, It is benign
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Yes
Any additional information for your reviewer? :
NA