feat(analytics): adding google analytics for ZFSPV #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
force-pushed
the
google
branch
5 times, most recently
from
f39c106
to
e297fcc
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
===========================================
- Coverage 83.33% 23.57% -59.76%
===========================================
Files 1 14 +13
Lines 72 475 +403
===========================================
+ Hits 60 112 +52
- Misses 12 362 +350
- Partials 0 1 +1
Continue to review full report at Codecov.
|
kmova
reviewed
Feb 27, 2020
|
Hi @pawanpraka1 : Can you update the PR description with the following details:
|
vharsh
reviewed
Feb 27, 2020
kmova
approved these changes
Feb 29, 2020
vharsh
reviewed
Mar 2, 2020
| @@ -647,6 +650,10 @@ spec: | |||
| value: unix:///var/lib/csi/sockets/pluginproxy/csi.sock | |||
| - name: OPENEBS_NAMESPACE | |||
| value: openebs | |||
| - name: OPENEBS_IO_INSTALLER_TYPE | |||
There was a problem hiding this comment.
Pending addition to helm charts cc @ChandanSagar
| // sendEventOrIgnore sends anonymous local-pv provision/delete events | ||
| func sendEventOrIgnore(pvName, capacity, stgType, method string) { | ||
| if zfs.GoogleAnalyticsEnabled == "true" { | ||
| analytics.New().Build().ApplicationBuilder(). |
There was a problem hiding this comment.
DoubleCheck: Confirm if AppName, AppID, AppVersion, etc are being set, etc.
Whenever a volume is provisioned and de-provisioned we will send a google event with mainly following details : 1. pvName (will shown as app title in google analytics) 2. size of the volume 3. event type : volume-provision, volume-deprovision 4. storage type zfs-localpv 5. replicacount as 1 6. ClientId as default namespace uuid Apart from this, we send the event once in 24 hr, which will have some info like number of nodes, node type, kubernetes version etc. This metric is cotrolled by OPENEBS_IO_ENABLE_ANALYTICS env. We can set it to false if we don't want to send the metrics. Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a volume is provisioned and de-provisioned we will send a google event with following details :
Apart from this, we send the event once in 24 hr, which will have some info like number of nodes, node type, kubernetes version etc.
This metric is cotrolled by OPENEBS_IO_ENABLE_ANALYTICS env. We can set it to false if we don't want to send the metrics.
Signed-off-by: Pawan pawan@mayadata.io