added developer environment examples #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filippo Bosi <filippo.bosi@gmail.com>
pawanpraka1
reviewed
Apr 23, 2020
|
|
||
| cd ~/go/src/github.com/openebs/zfs-localpv/tests | ||
|
|
||
| ginkgo -v |
There was a problem hiding this comment.
we can do sudo -E env "PATH=$PATH" make ci to run integration test after setting up the minikube and ZFS pool, see the doc : https://github.com/openebs/zfs-localpv/blob/master/docs/developer-setup.md#building-and-testing-your-changes.
|
thanks for this PR @filippobosi . |
kmova
approved these changes
Apr 27, 2020
kmova
added
the
Need community involvement
pawanpraka1
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
looks good, will refine this doc later. Thaks @filippobosi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filippo Bosi filippo.bosi@gmail.com
The documentation to setup development environment (from an os and minikube point of view) is not very detailed. I started writing down detailed notes on how to setup an environment and pass integration tests.