This repository has been archived by the owner on May 6, 2024. It is now read-only.
Social Auth Sign In With Apple Support #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
======================================
- Coverage 52% 52% -1%
======================================
Files 432 433 +1
Lines 26213 26268 +55
======================================
+ Hits 13784 13790 +6
- Misses 12429 12478 +49
Continue to review full report at Codecov.
|
mumer92
suggested changes
Aug 28, 2020
Source/AppleSocial.swift
Outdated
| class AppleSocial: NSObject { | ||
|
|
||
| static let shared = AppleSocial() | ||
| var completionHandler: AppleLoginCompletionHandler! |
There was a problem hiding this comment.
completionHandler can be made optional and private
Suggested change
| var completionHandler: AppleLoginCompletionHandler! | |
| private var completionHandler: AppleLoginCompletionHandler? |
mumer92
suggested changes
Aug 28, 2020
mumer92
approved these changes
Aug 31, 2020
salman2013
approved these changes
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-7697
This PR adds support of social auth with
Apple. Learners will be able to use their Apple credentials to login/register with our server.Notes
You will be able to register and sign in using the Apple credentials on the prod environment from mobile.
Sign in With Appleis not available on the prod web and it will be enabled when we will push the solution on mobile. To test a integration between mobile and web please use the stage environment.Testing