Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fact_current_enrollments model #101

Closed
wants to merge 3 commits into from

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented May 30, 2024

Description

This PR adds a model to get the latest enrollment status of a learner but with extra course and learner information.

partially fixes: openedx/wg-build-test-release#368

Changes need to be applied to Superset.

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 30, 2024
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to overlap a lot with fact_enrollment_status, but doesn't seem to actually limit to the most recent row? I think you should probably just make this join the user data onto that?

@Ian2012
Copy link
Contributor Author

Ian2012 commented May 30, 2024

It's the same data but with the joined course and user data, however, the MV will only be updated on changes to the enrollments, so if I join user pii with fact_enrollment_status the data will be outdated. fact_enrollment_status stored the latest enrollment status however the data is eventually consistent so I will add a group by clause

@openedx-webhooks
Copy link

@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Test failure] <TC_AUTHOR_REDWOOD_7>: < un-enrollment is not reflecting>
3 participants