Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve docs time #89

Merged
merged 2 commits into from
May 14, 2024
Merged

build: improve docs time #89

merged 2 commits into from
May 14, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented May 8, 2024

No description provided.

@openedx-webhooks
Copy link

openedx-webhooks commented May 8, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 8, 2024
@Ian2012 Ian2012 changed the base branch from cag/individual-learner-reports to main May 8, 2024 22:33
@Ian2012 Ian2012 force-pushed the tmp branch 2 times, most recently from b2bd913 to e1ad87d Compare May 8, 2024 22:39
@bmtcril
Copy link
Contributor

bmtcril commented May 9, 2024

Is it possible to just start ClickHouse, run alembic, then run dbt?

@Ian2012
Copy link
Contributor Author

Ian2012 commented May 9, 2024

I think so

@bmtcril
Copy link
Contributor

bmtcril commented May 9, 2024

Hmm we probably also need to run the init_clickhouse.sh script as well to set up databases and permissions, don't think there's a command for that yet but is probably worth it to add

@Ian2012 Ian2012 marked this pull request as ready for review May 9, 2024 14:19
@Ian2012 Ian2012 force-pushed the tmp branch 2 times, most recently from 08a7a45 to 633459f Compare May 14, 2024 14:04
@Ian2012 Ian2012 changed the title build: try faster docs build: improve docs time May 14, 2024
@Ian2012 Ian2012 requested a review from bmtcril May 14, 2024 14:18
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Ian2012 Ian2012 merged commit 0558ab8 into main May 14, 2024
4 checks passed
@Ian2012 Ian2012 deleted the tmp branch May 14, 2024 14:50
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants