Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed up setup.py #4

Merged
merged 1 commit into from
Feb 23, 2015
Merged

fixed up setup.py #4

merged 1 commit into from
Feb 23, 2015

Conversation

cgoldberg
Copy link
Contributor

I stumbled across your setup.py, and noticed a few funky things. Everything was valid, but kinda quirky and not idiomatic.

so, I:

  • removed the exec() call and just imported version
  • removed the 'read()' function and just read the file contents from within a context manager.

happy hacking,
-Corey

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6baedd2 on cgoldberg/fix-setup into b06324c on master.

@clintonb
Copy link
Contributor

👍

1 similar comment
@rlucioni
Copy link
Contributor

👍

cgoldberg added a commit that referenced this pull request Feb 23, 2015
@cgoldberg
Merge pull request #4 from edx/cgoldberg/fix-setup
cde1f00 
fixed up setup.py
@cgoldberg cgoldberg merged commit cde1f00 into master Feb 23, 2015
@rlucioni rlucioni deleted the cgoldberg/fix-setup branch February 23, 2015 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgoldberg @coveralls @clintonb @rlucioni