Send identify events to Segment before page events from ecommerce #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlasdairSwan
suggested changes
Feb 2, 2017
| if (this.options.courseModel.get('courseId')) { | ||
| return this.buildCourseProperties(); | ||
| pageData= this.buildCourseProperties(); |
There was a problem hiding this comment.
Nitpick: missing space between pageData and =.
rlucioni
approved these changes
Feb 2, 2017
| # ANALYTICS | ||
| # Specify a key to emit events to the corresponding Segment project. `None` disables tracking. | ||
| # See: https://segment.com/docs/libraries/python/ | ||
| SEGMENT_KEY = None |
There was a problem hiding this comment.
If this is unused, it should also be removed from edx/configuration; you may want to consult with Devops to see if any secure overrides need to be cleaned up.
Related: it's probably worth documenting how this is meant to be set up now.
There was a problem hiding this comment.
Good call, thanks @renzo for the suggestion
There was a problem hiding this comment.
mikedikan
force-pushed
the
mdikan/track-user-before-tracking-page
branch
from
103d505
to
d170c28
Compare
|
@AlasdairSwan please re-review |
mikedikan
force-pushed
the
mdikan/track-user-before-tracking-page
branch
2 times, most recently
from
81f8b06
to
5865f1c
Compare
Remove the SEGMENT_KEY from settings, this value is now set in Django admin and the value existing in settings can lead to developer confusion and frustration (ask me how I know this)
ECOM-6650 Calling the logging of the user to segment before calling the tracking function, so events are attributed to the correct user.
mikedikan
force-pushed
the
mdikan/track-user-before-tracking-page
branch
from
5865f1c
to
3527d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECOM-6650
Calling the logging of the user to segment before calling the tracking function, so events are attributed to the correct user. Also, small cleanup of settings file.
@edx/ecommerce for review