Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Support create-mobile-skus to run again if failed #4129

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

jawad-khan
Copy link
Contributor

@jawad-khan jawad-khan commented Feb 14, 2024

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

  • Before deploying this change, complete a purchase in the stage environment.
    (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

Support create-mobile-skus to run again if failed

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

@jawad-khan jawad-khan requested a review from a team as a code owner February 14, 2024 02:59
Copy link
Contributor

@moeez96 moeez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Testing end-to-end once now.

@moeez96
Copy link
Contributor

moeez96 commented Feb 15, 2024

Failing tests/pycodestyle formats to be fixed @jawad-khan

@moeez96
Copy link
Contributor

moeez96 commented Feb 15, 2024

End to end testing has passed on my end.

@jawad-khan jawad-khan merged commit 810162a into 2u/main Feb 15, 2024
9 of 10 checks passed
@jawad-khan jawad-khan deleted the LEARNER-9836 branch February 15, 2024 07:11
zubair-ce07 added a commit that referenced this pull request Feb 20, 2024
fix: sorted imports

Fix: Support create-mobile-skus to run again if failed (#4129)

* fix: Support create-mobile-skus to run again if we found an error previously

fix: Enable enrollment code purchase with mobile seats (#4130)

* fix: Enable enrollment code purchase with mobile seats

* test: Add unit test

---------

Co-authored-by: Abdul  Moeez Zahid <abdul.moeez@A006-01420.local>

fix: PEP8 conventions

fix: import issue

chore: added more test cases

fix: added new line at the end of file

fix: blank line issue

fix: long line issue

fix: pylint issues

fix: import issues

fix: removed extra blank line

fix: updated test

fix: issues in command

fix:: isort issue
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
* fix: Support create-mobile-skus to run again if we found an error previously
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
* fix: Support create-mobile-skus to run again if we found an error previously
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
* fix: Support create-mobile-skus to run again if we found an error previously
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
* fix: Support create-mobile-skus to run again if we found an error previously
abdullahwaheed pushed a commit to abdullahwaheed/ecommerce that referenced this pull request Mar 1, 2024
* fix: Support create-mobile-skus to run again if we found an error previously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants