Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update_voucher_names now can be run synchronously and can batch… #4137

Merged

Conversation

christopappas
Copy link
Contributor

… sleep

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

  • Before deploying this change, complete a purchase in the stage environment.
    (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

@christopappas christopappas requested a review from a team as a code owner February 23, 2024 21:07
Copy link
Contributor

@julianajlk julianajlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit on the help text

@christopappas christopappas merged commit 92f874e into openedx:2u/main Feb 26, 2024
10 checks passed
@christopappas christopappas deleted the cpappas/update-voucher-command branch February 26, 2024 18:15
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
#4137)

* feat: update_voucher_names now can be run synchronously and can batch sleep

* feat: update_voucher_name mgmt command can start at an offset

* fix: split update logic from task for quality reasons
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
#4137)

* feat: update_voucher_names now can be run synchronously and can batch sleep

* feat: update_voucher_name mgmt command can start at an offset

* fix: split update logic from task for quality reasons
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
#4137)

* feat: update_voucher_names now can be run synchronously and can batch sleep

* feat: update_voucher_name mgmt command can start at an offset

* fix: split update logic from task for quality reasons
zubair-ce07 pushed a commit that referenced this pull request Mar 1, 2024
#4137)

* feat: update_voucher_names now can be run synchronously and can batch sleep

* feat: update_voucher_name mgmt command can start at an offset

* fix: split update logic from task for quality reasons
abdullahwaheed pushed a commit to abdullahwaheed/ecommerce that referenced this pull request Mar 1, 2024
openedx#4137)

* feat: update_voucher_names now can be run synchronously and can batch sleep

* feat: update_voucher_name mgmt command can start at an offset

* fix: split update logic from task for quality reasons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants