Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable ORAs with reordered steps #2145

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Dec 18, 2023

TL;DR - remove the check that disabled new ORA experience for ORAs with reordered steps, now that we believe that feature is working.

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc4a5a9) 94.95% compared to head (855e0ea) 94.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   94.95%   94.94%   -0.01%     
==========================================
  Files         191      191              
  Lines       20538    20523      -15     
  Branches     1860     1857       -3     
==========================================
- Hits        19501    19486      -15     
  Misses        777      777              
  Partials      260      260              
Flag Coverage Δ
unittests 94.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nsprenkle nsprenkle merged commit e2970b7 into master Dec 18, 2023
9 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/bff-allow-reordered-oras branch December 18, 2023 17:55
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* feat: re-enable ORAs with reordered steps

* chore: bump ORA to 6.0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants