Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme mechanism doesn't work with i18n extraction #434

Closed
hanwentao opened this issue Jul 18, 2013 · 5 comments
Closed

Theme mechanism doesn't work with i18n extraction #434

hanwentao opened this issue Jul 18, 2013 · 5 comments

Comments

@hanwentao
Copy link

The current theme mechanism puts theme-related files in themes/ directory which is in the same parent directory as edx-platform. Pybabel cannot extract strings from directories outside edx-platform.

@natehardison
Copy link
Contributor

Would it be able to extract files from apps placed in INSTALLED_APPS? One
conversation we've had is about making the theme an app.

On Thursday, July 18, 2013, Wentao Han wrote:

The current theme mechanism puts theme-related files in themes/ directory
which is in the same parent directory as edx-platform. Pybabel cannot
extract strings from directories outside edx-platform.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/issues/434
.

Nate

@hanwentao
Copy link
Author

Where is INSTALLED_APPS? It's OK if it is under edx-platform/.

@natehardison
Copy link
Contributor

Hmm, that's not necessarily the case. INSTALLED_APPS is a list of Python
paths to Python packages that are on PYTHON_PATH, which isn't just
edx-platform. See
https://docs.djangoproject.com/en/dev/ref/settings/#installed-apps for more.

And I don't totally understand the issue here. We can still use the current
internationalization functions in our theme templates. Is the extraction
just an automated process to make internationalization easier?

Nate

On Thu, Jul 18, 2013 at 8:29 PM, Wentao Han notifications@github.comwrote:

Where is INSTALLED_APPS? It's OK if it is under edx-platform/.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/issues/434#issuecomment-21229647
.

@hanwentao
Copy link
Author

Yes. But the i18n extraction tool edx-platform/i18n/extract.py only works on files under edx-platform/ no matter how I changed edx-platform/conf/locale/babel.cfg.

chrisrossi pushed a commit to jazkarta/edx-platform that referenced this issue Mar 31, 2014
Add facility for fixed number of problem attempts
@singingwolfboy
Copy link
Contributor

I'm closing this issue for now. We're turning off Github Issues, because there are too many different places that people can go to ask for help. By reducing the number of places to ask for help, we're making it easier for knowledgable people to find people to help, so that everyone can help each other more effectively. If you still need help, try asking on our mailing lists or creating an issue on our public JIRA issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants