fix: support for newer npm and macOS #33506
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS does not support the `--force` flag in `cp`, so use the equivalent `-f` flag instead. Newer versions of npm also require `legacy-peer-deps` to be set to true to install successfully. They also no longer have the `npm bin` command, so use `npm root` instead.
|
Converting back to draft, as requirements installation failed when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an updated version of #33232. Author credit to @mohd-akram .
Testing
Mohamed tested this with
paver update_assets(the old assets build) on macOS.I tested it with
npm run build(the new assets build) on Ubuntu 22.04.