-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lytvynenko/learners count gradebook quince #33618
Lytvynenko/learners count gradebook quince #33618
Conversation
Thanks for the pull request, @Inferato! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
user_count = cache.get(cache_key, None) | ||
if user_count is None: | ||
user_count = queryset.count() | ||
cache.set(cache_key, user_count, cache_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can remove the import for the cache
now
Like it was done in the PR to master branch
Hi there! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against |
HI @mariajgrimaldi! Is this something you can merge? The master was closed, so I'm not sure if this is still in progress or not. |
@mphilbrick211: since the master PR was closed, I'll also close this one. If needed, another one should be opened with the new backported changes. Thanks! |
@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Caching is removed to represent an actual count of learners.
Related: master