feat: replace la waffle flag with django setting #34236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/update_la_waffle_flag
branch
2 times, most recently
from
d0709c6
to
ae73d07
Compare
MichaelRoytman
approved these changes
Feb 14, 2024
| @ddt.idata(itertools.product((True, False), (True, False))) | ||
| @ddt.unpack | ||
| def test_learning_assistant_enabled(self, setting_enabled, flag_enabled): | ||
| with override_settings(LEARNING_ASSISTANT_AVAILABLE=setting_enabled): |
There was a problem hiding this comment.
Nit.
You don't have to nest the context managers, if you don't want to. You can use them on one line.
alangsto
force-pushed
the
alangsto/update_la_waffle_flag
branch
4 times, most recently
from
6acca89
to
3b3bbac
Compare
alangsto
force-pushed
the
alangsto/update_la_waffle_flag
branch
from
3b3bbac
to
bf8ccef
Compare
zacharis278
approved these changes
Feb 20, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
COSMO-191
As we prepare for a wider release of the learning assistant, the feature should be controlled by a django setting as opposed to a per-course flag.
This PR should not be merged until edx/learning-assistant#67 has been merged, and a new release of the plugin has been deployed to production.