Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: third party authentication automatic logout with a single redirect #34517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Apr 16, 2024

Description

Current Third Party Authentication logout requires a redirect from the SSO IDP to the LMS to handle IDAs logout, i.e. we need to visit the <LMS>/logout twice. This PR attempts to handle the TPA logout with only one visit to <LMS>/logout.

Testing instructions

  1. Add TPA_AUTOMATIC_LOGOUT_ENABLED = True to edx-platform/lms/envs/devstack.py
  2. Replace self.tpa_logout_url = tpa_pipeline.get_idp_logout_url_from_running_pipeline(request) in edx-platform/openedx/core/djangoapps/user_authn/views/logout.py with self.tpa_logout_url = "https://example.com/logout" (to simplify testing)
  3. Launch LMS and Studio e.g. make dev.up.lms+cms
  4. Check the network tab and ensure that the user is logged out from both the LMS and Studio before being redirected to https://example.com/logout (fake IDP logout URL)

Supporting information

Private ref BB-8759

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 16, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 16, 2024

Thanks for the pull request, @CefBoud!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@CefBoud CefBoud force-pushed the CefBoud/BB-8759/tpa-logout branch from b42f6b8 to e8c942c Compare June 10, 2024 09:08
@CefBoud CefBoud changed the title feat: tpa automatic logout with a single redirect feat: third party authentication automatic logout with a single redirect Jun 10, 2024
@CefBoud
Copy link
Contributor Author

CefBoud commented Jun 10, 2024

This is ready for review.

@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants