Paver Removal 2/3 #34830
Draft
Paver Removal 2/3 #34830
+103
−1,683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Merged
Draft
Open
kdmccormick
force-pushed
the
kdmccormick/paver-rm-2
branch
from
e729718
to
3f77cf6
Compare
As of Python 3.3, the 3rd-party 'mock' package has been subsumed into the standard 'unittest.mock' package. Refactoring tests to use the latter will allow us to drop 'mock' as a dependency, which is currently coming in transitively through paver.in.
kdmccormick
force-pushed
the
kdmccormick/paver-rm-2
branch
from
3f77cf6
to
b14b788
Compare
These packages were installed transitively through paver.in, but they are used as direct dependencies in edx-platform application code: * psutil * pymemcache * wrapt Since we are demoting paver.in to be a dev-only dependency (with plans to remove paver.in entirely), we need to make those three packages explicit dependencies in kernel.in Part of: openedx#34467
kdmccormick
force-pushed
the
kdmccormick/paver-rm-2
branch
from
1d7c978
to
e2873c3
Compare
TODO details Part of: openedx#34467
Commit generated by workflow: `kdmccormick/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: Kyle McCormick <kyle@axim.org>
kdmccormick
force-pushed
the
kdmccormick/paver-rm-2
branch
from
4d524cf
to
c184394
Compare
kdmccormick
added a commit
that referenced
this pull request
May 22, 2024
As of Python 3.3, the 3rd-party `mock` package has been subsumed into the standard `unittest.mock` package. Refactoring tests to use the latter will allow us to drop `mock` as a dependency, which is currently coming in transitively through requirements/edx/paver.in. We don't actually drop the `mock` dependency in this PR. That will happen naturally in: * #34830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pavelib/prereqs.py:*pavelib/assets.py:*./manage.py [lms|cms] compile_sass, which was just a wrapper around Paver commands.Supporting info
This is part of:
Previous work (blocking this):
mockwithunittest.mockedx-proctoring#1207Next PR:
Testing instructions
None. For the community deployment, this is all dead code. The replacement (
npm run) was thoroughly tested as part of the linked DEPR ticket.Merge considerations: